[REVIEW] Single-linkage Hierarchical Clustering C++ #3545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: cpp/src_prims/sparse/coo.cuh
cjnolet
changed the title
cjnolet
commented
Mar 16, 2021
divyegala
approved these changes
Mar 16, 2021
dantegd
added
4 - Waiting on Author
dantegd
approved these changes
Mar 17, 2021
dantegd
added
4 - Waiting on Reviewer
mike-wendt
approved these changes
Mar 17, 2021
|
rerun tests |
|
@gpucibot merge |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #3545 +/- ##
================================================
- Coverage 80.72% 45.27% -35.46%
================================================
Files 228 224 -4
Lines 17629 17059 -570
================================================
- Hits 14231 7723 -6508
- Misses 3398 9336 +5938
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
rerun tests |
|
@cjnolet I think the logs are showing an error in the doxygen docstring: /var/lib/jenkins/workspa/var/lib/jenkins/workspace/rapidsai/gpuci/cuml/prb/cuml-gpu-test/CUDA/10.2/GPU_LABEL/gpu/OS/centos7/PYTHON/3.8/cpp/include/cuml/cluster/linkage.hpp:79: error: unbalanced grouping commands (warning treated as error, aborting now)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3518
I've closed the original PR (#3308) which included both SLHC & HDBSCAN and opened this PR to only include the SLHC changes.
This PR contains an implementation of SLHC which is currently broken across RAFT & cuML. Once we move the dense pairwise distance primitive over to RAFT the entire SLHC algorithm can live in RAFT so it can be shared w/ cugraph, and will just be exposed through cuml.
If reviewing this PR, please also review the corresponding RAFT PR: rapidsai/raft#140