Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] SimpleImputer fix #3624

Merged
merged 33 commits into from
Apr 1, 2021
Merged

[REVIEW] SimpleImputer fix #3624

merged 33 commits into from
Apr 1, 2021

Conversation

viclafargue
Copy link
Contributor

Closes #3599

In this PR MissingIndicator is implemented, exposed and tested. The add_indicatorparameter of SimpleImputer is now tested.

@viclafargue
cuML Base estimator class for preprocessing models
94d845f
@viclafargue
cuml_function decorator
653b9cf
@viclafargue
Cleaning code
4bf0c2d
@viclafargue
Adding missing tags
d8b56bc
@viclafargue
Merge branch 'branch-0.18' into fea-cuml-base-for-preproc
3545bfb
@viclafargue
Changelog update
d64c1d1
@viclafargue
Check style
ef74d52
@viclafargue
Updated adapters testing
ff1f419
@viclafargue
Relative imports
829eabc
@viclafargue
Remove cuml_function
4bcae89
@viclafargue
Remove cuml_estimator
ca93dc5
@viclafargue
Update get_param_names
dba3f37
@viclafargue
Update __init_subclass__
4ed8be3
@viclafargue
Update get_param_names
4b6bda4
@viclafargue
Exemption for docstring
031ecf4
@viclafargue
Restoring KernelCenterer, QuantileTransformer, and PowerTransformer code
f25ab52
@viclafargue
Update coding style
42b6475
@viclafargue
Merge branch 'branch-0.18' into fea-cuml-base-for-preproc
5827536
@viclafargue
Merge branch 'branch-0.18' into fea-cuml-base-for-preproc
96c64d4
@viclafargue
Tags deepcopy fix
0e467f8
@viclafargue
Fix for KBinsDiscretizer
298c3c3
@viclafargue
Merge branch 'branch-0.18' into fea-cuml-base-for-preproc
65d5226
@viclafargue
Merge branch 'branch-0.19' into fea-cuml-base-for-preproc
0e4f994
@viclafargue
Update copyright header
a18f5f6
@viclafargue
Remove changelog entry
7e15903
@viclafargue
Merge branch 'branch-0.19' into fea-cuml-base-for-preproc
ec001b5
@viclafargue
Add MissingIndicator
ddde448
@viclafargue
Update int_dataset dataset
52f2614
@viclafargue
Update SimpleImputer testing
bc23837
@viclafargue viclafargue requested a review from a team as a code owner March 16, 2021 18:17
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Mar 16, 2021
@viclafargue viclafargue added bug Something isn't working non-breaking Non-breaking change and removed Cython / Python Cython or Python issue labels Mar 16, 2021
@viclafargue viclafargue changed the title [REVIEW] Simpleimputer fix [WIP] Simpleimputer fix Mar 16, 2021
@viclafargue viclafargue added the 2 - In Progress Currenty a work in progress label Mar 16, 2021
@viclafargue viclafargue changed the title [WIP] Simpleimputer fix [WIP] SimpleImputer fix Mar 16, 2021
@JohnZed
Copy link
Contributor

JohnZed commented Mar 18, 2021

Wait for #3270

@viclafargue viclafargue added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Mar 29, 2021
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Mar 29, 2021
@viclafargue
Copy link
Contributor Author

rerun tests

@JohnZed
Copy link
Contributor

JohnZed commented Mar 30, 2021

@lowener can you take a look at this review?

lowener
lowener approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@lowener lowener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viclafargue viclafargue added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Mar 31, 2021
@JohnZed JohnZed changed the title [WIP] SimpleImputer fix [REVIEW] SimpleImputer fix Apr 1, 2021
@JohnZed
Copy link
Contributor

JohnZed commented Apr 1, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 55002a7 into rapidsai:branch-0.19 Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lowener lowener lowener approved these changes

@JohnZed JohnZed JohnZed approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Not able to add missing indicator in SimpleImputer
3 participants
@viclafargue @JohnZed @lowener