Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Update LogisticRegression documentation #3677

Merged

Conversation

viclafargue
Copy link
Contributor

Closes #3671

@viclafargue viclafargue requested a review from a team as a code owner March 31, 2021 16:07
@viclafargue viclafargue added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 31, 2021
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Mar 31, 2021
@dantegd
Copy link
Member

dantegd commented Mar 31, 2021

@gpucibot merge

@codecov-io
Copy link

Codecov Report

Merging #3677 (287c597) into branch-0.19 (8316807) will increase coverage by 8.19%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #3677      +/-   ##
===============================================
+ Coverage        74.11%   82.31%   +8.19%     
===============================================
  Files              214      227      +13     
  Lines            16660    17541     +881     
===============================================
+ Hits             12348    14439    +2091     
+ Misses            4312     3102    -1210     
Flag Coverage Δ
dask 46.40% <ø> (?)
non-dask 74.28% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/linear_model/logistic_regression.pyx 89.16% <ø> (ø)
python/cuml/common/numba_utils.py 0.00% <0.00%> (ø)
python/cuml/internals/global_settings.py 100.00% <0.00%> (ø)
python/cuml/cluster/kmeans_mg.pyx 82.60% <0.00%> (ø)
python/cuml/linear_model/base_mg.pyx 100.00% <0.00%> (ø)
python/cuml/decomposition/pca_mg.pyx 96.36% <0.00%> (ø)
python/cuml/cluster/dbscan_mg.pyx 100.00% <0.00%> (ø)
python/cuml/decomposition/tsvd_mg.pyx 100.00% <0.00%> (ø)
python/cuml/neighbors/kneighbors_classifier_mg.pyx 100.00% <0.00%> (ø)
python/cuml/common/opg_data_utils_mg.pyx 98.97% <0.00%> (ø)
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8316807...287c597. Read the comment docs.

@JohnZed JohnZed added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Mar 31, 2021
@dantegd
Copy link
Member

dantegd commented Apr 1, 2021

rerun tests

@rapids-bot rapids-bot bot merged commit daf0d14 into rapidsai:branch-0.19 Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] LogisticRegression coef array does not include intercept if fit_intercept=True
4 participants