Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emissions workflow enhancements #233

Merged
merged 9 commits into from
Jun 27, 2022
Merged

Emissions workflow enhancements #233

merged 9 commits into from
Jun 27, 2022

Conversation

rawadelkontar
Copy link
Contributor

Resolves #[issue number here]

Pull Request Description

Restrict emission inputs definition to only site_properties

Checklist (Delete lines that don't apply)

  • Unit tests have been added or updated
  • Documentation has been modified appropriately
  • All ci tests pass (green)
  • An issue has been created (which will be used for the changelog)
  • This branch is up-to-date with develop

@rawadelkontar rawadelkontar requested a review from kflemin May 25, 2022 22:22
Copy link
Contributor

@kflemin kflemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good! can you add a test that validates a file with emissions data defined, and one that fails when an emissions value (ex: emissions_future_subregion) is wrong? thanks!

@kflemin kflemin self-requested a review June 27, 2022 20:41
@kflemin kflemin merged commit 3345753 into develop Jun 27, 2022
@kflemin kflemin deleted the emissions branch June 27, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants