deprecation warnings

[scr4bble]

After updating fedora to version 32 I had to install py_sg again.
Now it works again but there is this warning in console:

$ wdpassport-utils.py -u
/usr/local/bin/wdpassport-utils.py:131: DeprecationWarning: PY_SSIZE_T_CLEAN will be required for '#' formats
data = py_sg.read_as_bin_str(dev, _scsi_pack_cdb(cdb), BLOCK_SIZE)
[wdpassport] password for /dev/sdb:
/usr/local/bin/wdpassport-utils.py:89: DeprecationWarning: PY_SSIZE_T_CLEAN will be required for '#' formats
data = py_sg.read_as_bin_str(dev, _scsi_pack_cdb(cdb), BLOCK_SIZE)
/usr/local/bin/wdpassport-utils.py:230: DeprecationWarning: PY_SSIZE_T_CLEAN will be required for '#' formats
py_sg.write(dev, _scsi_pack_cdb(cdb), _scsi_pack_cdb(pw_block) + pwd_hashed)

Python 3.8.6

[alex9434]

I have the same warnings on Debian 11 stable (bullseye):

/usr/local/bin/wdpassport-utils.py:131: DeprecationWarning: PY_SSIZE_T_CLEAN will be required for '#' formats
  data = py_sg.read_as_bin_str(dev, _scsi_pack_cdb(cdb), BLOCK_SIZE)
[wdpassport] password for /dev/sdc: 
/usr/local/bin/wdpassport-utils.py:89: DeprecationWarning: PY_SSIZE_T_CLEAN will be required for '#' formats
  data = py_sg.read_as_bin_str(dev, _scsi_pack_cdb(cdb), BLOCK_SIZE)
/usr/local/bin/wdpassport-utils.py:230: DeprecationWarning: PY_SSIZE_T_CLEAN will be required for '#' formats
  py_sg.write(dev, _scsi_pack_cdb(cdb), _scsi_pack_cdb(pw_block) + pwd_hashed)
[*] Device unlocked.

[sicr0]

Same here, anyone knows what needs to be changed in the code?

[tvladyslav]

This should help
tvladyslav/py3_sg#1

All thanks to @Lasoloz

[scr4bble]

Nice! Thank you @tvladyslav @Lasoloz
So seems like we can close this issue, right?

There is another problem now that the script refers to the library as py_sg and it should be py3_sg so the import fails.

[scr4bble]

@tvladyslav could you please make a PR from your repo back here with usage of the py3_sg instead of py_sg? I see you already fixed it in your fork.
It would be highly appreciated.

[tvladyslav]

@scr4bble this repo is stale for 3 years. 3 PRs pending. I doubt it is worth make one more PR.

[scr4bble]

Then let's maybe at least create an issue here and reference your repository so people can find it. I managed to fix it myself and only then found your repo.