Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to install the plugin using fisher v4.3.1 #36

Closed
gsshiva opened this issue Jan 30, 2022 · 2 comments
Closed

Unable to install the plugin using fisher v4.3.1 #36

gsshiva opened this issue Jan 30, 2022 · 2 comments

Comments

@gsshiva
Copy link

gsshiva commented Jan 30, 2022

The Project documentation says the following to install using fisher

fisher add 0rax/fishline

but on fisher version 4.3, there is no such option as add and only install. The following commands only brings in just fishline.fishand nothig else.

% fisher -v
fisher, version 4.3.1

% fisher install 0rax/fishline
fisher install version 4.3.1
In config.fish /home/GSS
Fetching https://codeload.github.com/0rax/fishline/tar.gz/HEAD
Installing 0rax/fishline
           /home/shiva/.config/fish/functions/fishline.fish
Installed 1 plugin/s

Creating a fish prompt as below

function fish_prompt
    fishline -s $status
end

results in the following

__fishline_segment_close: command not found
~/.config/fish/functions/fishline.fish (line 71): 
    __fishline_segment_close
    ^
in function 'fishline' with arguments '-s 0'
	called on line 2 of file ~/.config/fish/functions/fish_prompt.fish
in function 'fish_prompt'
in command substitution

Let me know what I am missing. Thanks for your work.

@0rax
Copy link
Owner

0rax commented Mar 3, 2022

Thanks for your report, I do not personally use fisher in part due to how the API tends not to be that much stable.

I will look into it right now trying to figure out how can I make the package install correctly once again.

@0rax
Copy link
Owner

0rax commented Mar 4, 2022

Another issue exist to report incompatibility with fisher >=4, I will close this issue as duplicate and continue tracking this issue in #33.

@0rax 0rax closed this as completed Mar 4, 2022
@0rax 0rax added the duplicate label Mar 4, 2022
This was referenced Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants