Missing aggregate.cov

[wumb0]

Between v0.3.2 and v0.4 the fuzzing server stopped generating the aggregate.cov file. The code was in server.h.
The README still indicates that the fuzz server maintains an aggregate coverage file "coverage.cov".

Was this removed on purpose? As the README indicates, it's useful to have a single aggregate coverage file.

Of course I do realize I can just generate cov traces via the run command using the output directory as the --input argument and then concat them into a single trace file, but since it's still in the readme I wanted to inquire. I think Lighthouse has the "Code coverage batch" option too, which would do the same thing.

[0vercl0k]

Hello!

Sorry for the delay - I am mostly away from computer until November :)

Yeah I did remove it on purpose because I started to question how useful it was. Also, I seem to remember that when adding the edge coverage for bxcpu, the file became less useful has it had a bunch of values that weren't 'real' addresses. I can't remember exactly how annoying it'd be to log only valid ones.

I'd definitely be open to try to re-add this / review a PR if you think it's worth it :)

Cheers

[0vercl0k]

Okay - I am getting to the end of my backlog so I'll start thinking about this. Let me know if this is still of interest to you @wumb0 :)

Cheers

[0vercl0k]

All right - in the end I opted for a hack; the client will make sure that the edge values are non canonical values & the server will only include canonical values in the aggregate.cov.

Please give the PR a shot and let me know what you think @wumb0 :)

Cheers

[0vercl0k]

Gentle ping @wumb0 !

Cheers