Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link containers on transcipt have large margins #44

Open
0x65-e opened this issue Jan 27, 2023 · 0 comments
Open

Link containers on transcipt have large margins #44

0x65-e opened this issue Jan 27, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@0x65-e
Copy link
Owner

0x65-e commented Jan 27, 2023

#43 added margin-top: 1em to .link-container h3 to resolve spacing issues on the resume page. This introduced unintentional issues on the transcript page since course headers also use h3 elements inside link containers.

Possible solutions:

  • Add CSS classes for h3 elements to indicate whether they should be spacing-adjusted or not
  • Modify the macro for course listings to manually style the h3 elements

This same issue may crop up again for h4 elements in the future, since their spacing was also adjusted. To resolve these issues, the best approach is probably to create new CSS classes.

@0x65-e 0x65-e added the bug Something isn't working label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant