Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] accept comments in block list entries #859

Closed
shizunge opened this issue Feb 1, 2023 · 0 comments · Fixed by #866
Closed

[Feature Request] accept comments in block list entries #859

shizunge opened this issue Feb 1, 2023 · 0 comments · Fixed by #866
Labels
🔨 enhancement New feature or request
Milestone
v0.21

Comments

@shizunge
Copy link
Contributor

shizunge commented Feb 1, 2023

One of my blocking list has comments.

https://gitlab.com/quidsup/notrack-blocklists/raw/master/notrack-blocklist.txt

e.g.

growsumo.com #PartnerStack - Tracker
growth-pa.googleapis.com #Google - Advertising

It seems blocky does not block these domains, while pi-hole did block these domains.

Can we enhance blocky to read the list with comments?
@kwitsch kwitsch changed the title blocking list with comments [Feature Request] accept comments in block list entries Feb 1, 2023
@kwitsch kwitsch added the 🔨 enhancement New feature or request label Feb 1, 2023
@ThinkChaos ThinkChaos mentioned this issue Feb 7, 2023
Merged
@0xERR0R 0xERR0R added this to the 0.21 milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔨 enhancement New feature or request
Projects
None yet
Milestone
v0.21
Development

Successfully merging a pull request may close this issue.

fix: ignore end of line comments when parsing lists ThinkChaos/blocky
3 participants
@shizunge @kwitsch @0xERR0R