Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix join game flow race condition (regression) #123

Open
norswap opened this issue Feb 21, 2024 · 0 comments
Open

Fix join game flow race condition (regression) #123

norswap opened this issue Feb 21, 2024 · 0 comments

Comments

@norswap
Copy link
Member

norswap commented Feb 21, 2024

There seems to be a regression whereas if both player send their drawInitialHand transaction at the same time there is a race condition (which is also not resolved by resending the transaction, though possible that's because of client-side caching of the drawn cards?).

This didn't used to be the case (I tested this explicitly).

In particular, I'm having an easy time triggering this by creating a game in browser 1 (firefox), joining with browser 2 (chrome) then immediately going back to browser 1 and joining too.

This was discovered while reviewing #107 (but mostly likely isn't the cause).

First order of business should be to figure out what introduced this regression. Could it be the contract refactor? Some more recent frontend changes, however unlikely?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant