Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review is syncing endpoint #1798

Closed
arnaubennassar opened this issue Mar 10, 2023 · 3 comments
Closed

Review is syncing endpoint #1798

arnaubennassar opened this issue Mar 10, 2023 · 3 comments
Labels
rpc
Milestone
v0.1.0

Comments

@arnaubennassar
Copy link
Member

highest block always return 0, but it's impossible to know whats the latest block (aka L2 tx), we can only know the last batch 🤔
@arnaubennassar
Copy link
Member Author

Looks like this is an endpoint that we will have to customise a bit, some ideas:

  • add extra fields in the JSON response: current/highest batch
  • Put an arbitrary gap between current/highest block if the node is not fully synced

We need to explain this discrepancy!

@tclemos
Copy link
Contributor

tclemos commented Apr 3, 2023

depends on #1918

@tclemos tclemos added this to the Release 0.1.0 milestone May 4, 2023
@ToniRamirezM
Copy link
Contributor

Closed in #2055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rpc
Projects
None yet
Milestone
v0.1.0
Development

No branches or pull requests
3 participants
@tclemos @arnaubennassar @ToniRamirezM