Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge boundary constraints into AlgebraicGraph and support variables #106

Closed
Tracked by #75 ...
tohrnii opened this issue Dec 22, 2022 · 2 comments
Closed
Tracked by #75 ...
Assignees

Comments

@tohrnii
Copy link
Contributor

tohrnii commented Dec 22, 2022

Variable support to transition constraint was added in #100. We should also add support for variables to boundary constraints. It might be useful to also add boundary constraints to the constraints graph in the same PR we add the variables.

The original issue with syntax is described in #61.

@grjte
Copy link
Contributor

grjte commented Jan 11, 2023

It now looks like we should do this task before completing #56, since having the boundary constraints in the constraints graph will simplify GCE generation a lot

In addition, to avoid rebuilding a lot of the symbol table information during the GCE codegen, we should consider some other adjustments to the IR:

  • accumulate the inline constants while building the graph. We can use this info in the future for optimizations, and we can use it directly in the GCE codegen instead of accumulating them there
  • provide access to the identifiers. A subset of this information is required during the GCE codegen. To avoid rebuilding it, we can either provide read access to all of the identifiers or we could provide just the subset we need, but since that's more work I'm inclined to just make the identifiers readable, since it's the simplest approach. We can think about readjustments later.

@grjte
Copy link
Contributor

grjte commented Feb 22, 2023

Closed by #116 #117 #126 and #160

@grjte grjte closed this as completed Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants