Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace errors in IR to call constructor methods #109

Closed
tohrnii opened this issue Dec 23, 2022 · 1 comment
Closed

Replace errors in IR to call constructor methods #109

tohrnii opened this issue Dec 23, 2022 · 1 comment
Assignees
@jjcnn
Labels
good first issue Good for newcomers IR

Comments

@tohrnii
Copy link
Contributor

tohrnii commented Dec 23, 2022

It would be better to refactor the errors in IR to call constructor methods for SemanticError instead of building the error string where the error is thrown. This will improve code readbility.

Originally proposed by @bobbinth in #94 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjcnn jjcnn

Labels
good first issue Good for newcomers IR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor to use SemanticError constructors for errors 0xPolygonMiden/air-script
3 participants
@jjcnn @grjte @tohrnii