You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The first will emit the following code for the winterfell backend:
fn get_aux_assertions<E: FieldElement<BaseField = Felt>>(&self, aux_rand_elements: &AuxTraceRandElements<E>) -> Vec<Assertion<E>> {
let mut result = Vec::new();
result.push(Assertion::single(0, 0, E::ONE));
result.push(Assertion::single(0, self.last_step(), E::ONE));
result
}
And the later
fn get_aux_assertions<E: FieldElement<BaseField = Felt>>(&self, aux_rand_elements: &AuxTraceRandElements<E>) -> Vec<Assertion<E>> {
let mut result = Vec::new();
result.push(Assertion::single(0, self.last_step(), E::ONE));
result.push(Assertion::single(0, 0, E::ONE));
result
}
The issue is that the order of Vec<Assertion<E>> determines the order of the composition coefficients, so proofs of the two systems above are not interchangeable. Additionally, this may introduce bugs across different backends, since the order of the coefficients is implicitly defined and can easily become out of sync.
To fix the issue above an ordering is required. A proposal is to sort by (trace, column_name, step), similar to #314
The text was updated successfully, but these errors were encountered:
On thing that I forgot. Winterfell does sort assertions by something similar to (stride, step, column), which is total. So the proofs should be fine, unlike what I wrote above. The issue is more on the backends.
Edit: To implement this some changes to the IR are necessary. The information is lost when creating the Algebraic graph, since the boundary constraint can be defined in term of other columns, enf a.first = b, looking for the trace access is not sufficient. And when the constraint boundary definitions are not forwarded from the constraint builder to the air definition.
The order in which the boundary constraints are defined is important. For example:
Is not the same as:
The first will emit the following code for the winterfell backend:
And the later
The issue is that the order of
Vec<Assertion<E>>
determines the order of the composition coefficients, so proofs of the two systems above are not interchangeable. Additionally, this may introduce bugs across different backends, since the order of the coefficients is implicitly defined and can easily become out of sync.To fix the issue above an ordering is required. A proposal is to sort by
(trace, column_name, step)
, similar to #314The text was updated successfully, but these errors were encountered: