Tracking issue: Improved ergonomics for defining constraints in AirScript

[grjte]

Goal(s)

• better ergonomics when defining constraints in AirScript

Details

To improve the ergonomics of the AirScript language, we should add support for:

• defining intermediate variables with the let keyword with these 3 types: scalars, vectors, matrices
• declaring named constants with these 3 types: scalars, vectors, matrices
• grouping columns (e.g.: a[4]) for
  • declarations in the trace_columns section
  • codegen referencing groups of columns (e.g. for generating one of the structs Polygon Zero uses when defining constraints)

Tasks

Preview Give feedback

We're having trouble rendering your tasklist, it's most likely has one of the following formatting errors:

• indented tasks (i.e. nested tasklist; support for this is coming!)
• an empty task (i.e. - [ ] on a line by itself)
• any empty new lines (before/after the tasklist or in between tasks)
• duplicate issue/pr links
• a draft task exceeds 512 characters

Please check the tasklists documentation for more information. 🔗 Feedback Discussion

Thank you for participating in the Private Beta ❤️

1. Add support for intermediate variables (scalars, vectors, matrices) #61
   IR codegen parser v0.2 +4
   
2. Add support for declaring named constants (scalars, vectors, matrices) #60
   IR codegen parser v0.2 +4
   
3. Add support for grouping of trace columns to parser #83
   parser v0.2 +2
   
4. Update IR to preserve column groupings for codegen #85
   IR v0.2 +2
   

Tasks

Preview Give feedback

We're having trouble rendering your tasklist, it's most likely has one of the following formatting errors:

• indented tasks (i.e. nested tasklist; support for this is coming!)
• an empty task (i.e. - [ ] on a line by itself)
• any empty new lines (before/after the tasklist or in between tasks)
• duplicate issue/pr links
• a draft task exceeds 512 characters

Please check the tasklists documentation for more information. 🔗 Feedback Discussion

Thank you for participating in the Private Beta ❤️

1. List Comprehension #87
   enhancement v0.3 +2
   
2. Add section for random values and allow declaring names for accessing random values #86
   enhancement v0.2 +2
   
3. Consider moving constants to the top of the AirScript file #89
   v0.2 +1
   
4. add support for $main and $aux built-ins #26
   enhancement v0.2 +2
   

Working group:

@Al-Kindi-0, @grjte, @Overcastan, @tohrnii

Workflow

• Discussion should happen here or in the related sub-issues.
• PRs should only be merged by the coordinator, to ensure everyone is able to review.
• Aim to complete reviews within 24 hours.
• When a related sub-issue is opened:
  • add it to the list of sub-issues in this tracking issue
• When opening a related PR:
  • request review from everyone in this working group
• When a sub-issue is completed:
  • close the related issue with a comment that links to the PR where the work was completed

Coordinator: @tohrnii

The working group coordinator ensures scope & progress tracking are transparent and accurate. They will:

• Merge approved PRs after all working group members have completed their reviews.
  • add the PR # to the relevant section of the current tracking PR.
  • close any completed sub-issue(s) with a comment that links to the PR where the work was completed
• Monitor workflow items and complete anything that slips through the cracks.
• Monitor scope to see if anything is untracked or unclear. Create missing sub-issues or initiate discussion as required.
• Monitor progress to see if there's anything which isn't moving forward. Initiate discussion as required.
• Identify PRs with especially significant changes and add @grjte and @bobbinth for review.

[grjte]

Do we want to use column-major or row-major form for matrices? (#63 (comment)) This affects many of the sub-issues here.

@bobbinth what do you think?

[bobbinth]

Ultimately, I don't think it matters since we can always transform one form to the other outside of the file. However, since we have to pick something, I think we should go with w/e is convenient for our current use cases.

Currently, the only use case for matrix constants is MDS matrix multiplication in Rescue constraints. There, I believe we need to iterate over rows to perform matrix-vector multiplication. So, I think this means that we should go with row-major form.

[Dominik1999]

Any progress here? Do you need anything to be unblocked?

[tohrnii]

@Dominik1999 Issues 60 and 61 are currently being worked on and will most likely be completed this week and 83 and 85 will probably also be completed this week. Nothing seems to be a blocker at the moment.

[Dominik1999]

Thanks @tohrnii so all "Must Have" Issues will be completed this week?

[Dominik1999]

@tohrnii still all good here?

[tohrnii]

@Dominik1999 Yes, the PRs for all the must haves are currently open and should be merged this week.

[grjte]

The completion of #87 has moved to #162