Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of Smt::sorted_pairs_to_leaves #348

Closed
krushimir opened this issue Nov 29, 2024 · 4 comments
Closed

Improve performance of Smt::sorted_pairs_to_leaves #348

krushimir opened this issue Nov 29, 2024 · 4 comments

Comments

@krushimir
Copy link

Smt::sorted_pairs_to_leaves function uses a current_leaf_buffer vector to track key-value pairs corresponding to a single leaf. Consider refactoring this logic to use an enum as a buffer to improve performance.

(from #341 comment)
@krushimir krushimir mentioned this issue Nov 29, 2024
Merged
@bobbinth
Copy link
Contributor

@krushimir - is this addressed/resolved as a part of #365?

@krushimir
Copy link
Author

No, addressed in a separate PR in a forked repo - can be merged to #365 though.

@krushimir
Copy link
Author

@bobbinth this is now addressed/resolved in #365

@bobbinth
Copy link
Contributor

bobbinth commented Feb 7, 2025

Closed by #365.

@bobbinth bobbinth closed this as completed Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bobbinth @krushimir