Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate adding type to StoragePlaceholder #1051

Closed
igamigo opened this issue Jan 8, 2025 · 2 comments
Closed

Investigate adding type to StoragePlaceholder #1051

igamigo opened this issue Jan 8, 2025 · 2 comments
Milestone

Comments

@igamigo
Copy link
Collaborator

igamigo commented Jan 8, 2025

On #1015, we add StoragePlaceholder for defining template values in the storage layout of AccountComponentMetadata. On instantiation, these are meant to be replaced by one StorageValue per placeholder.
The placeholders could take the value of a felt, word, or map, so one potential improvement to the workflow could be to make StoragePlaceholder carry the type of the expected value. This could help the user query which type of values each key requires, so that they could check beforehand that all are correct before actually instantiating.
When deserializing a toml component, the type could be picked up according to the place the placeholder is located at.

@bobbinth
Copy link
Contributor

This is being addressed in #1074, right?

@igamigo
Copy link
Collaborator Author

igamigo commented Jan 21, 2025

Sorry I missed the comment before. Yes, this was closed by #1074

@igamigo igamigo closed this as completed Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants