Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor decoder handling of control blocks #1538

Open
plafer opened this issue Oct 21, 2024 · 0 comments
Open

Refactor decoder handling of control blocks #1538

plafer opened this issue Oct 21, 2024 · 0 comments
Labels
processor Related to Miden VM processor

Comments

@plafer
Copy link
Contributor

plafer commented Oct 21, 2024

When encountering a control block (e.g. JOIN), writing to the system and stack columns is handled by calling self.execute_op(Operation::Noop). This is unintuitive, makes debugging harder (e.g. a print inside execute_op() prints a bunch of NOOP operations that are not actually in the trace). Also, DYNCALL was the first control block where its effect on the stack and system columns doesn't correspond to any existing operation.

The real purpose of "executing NOOPs" is to

  1. ensure the trace capacity
  2. copy the stack columns over to the next row
  3. advance clock

We should introduce an abstraction that does this cleanly instead of reusing execute_op().

Context: #1535 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor Related to Miden VM processor
Projects
None yet
Development

No branches or pull requests

1 participant