You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When encountering a control block (e.g. JOIN), writing to the system and stack columns is handled by calling self.execute_op(Operation::Noop). This is unintuitive, makes debugging harder (e.g. a print inside execute_op() prints a bunch of NOOP operations that are not actually in the trace). Also, DYNCALL was the first control block where its effect on the stack and system columns doesn't correspond to any existing operation.
The real purpose of "executing NOOPs" is to
ensure the trace capacity
copy the stack columns over to the next row
advance clock
We should introduce an abstraction that does this cleanly instead of reusing execute_op().
When encountering a control block (e.g.
JOIN
), writing to the system and stack columns is handled by callingself.execute_op(Operation::Noop)
. This is unintuitive, makes debugging harder (e.g. a print insideexecute_op()
prints a bunch ofNOOP
operations that are not actually in the trace). Also,DYNCALL
was the first control block where its effect on the stack and system columns doesn't correspond to any existing operation.The real purpose of "executing NOOPs" is to
We should introduce an abstraction that does this cleanly instead of reusing
execute_op()
.Context: #1535 (comment)
The text was updated successfully, but these errors were encountered: