Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node before_enter/after_exit are not coherent with set_{before_enter,_after_exit} #1604

Open
paracetamolo opened this issue Dec 17, 2024 · 0 comments
Open

Node before_enter/after_exit are not coherent with set_{before_enter,_after_exit} #1604

paracetamolo opened this issue Dec 17, 2024 · 0 comments
Assignees
@paracetamolo
Labels
good first issue Good for newcomers

Comments

@paracetamolo
Copy link

What should be done?

Setting and getting should return the same result.

How should it be done?

@plafer suggested to error/panic in the Block case.

When is this task done?

A test with self.before_enter(self.set_before_enter(ids)) == ids should pass for all node variants.

Additional context

No response
@paracetamolo paracetamolo self-assigned this Dec 17, 2024
@paracetamolo paracetamolo added the good first issue Good for newcomers label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paracetamolo paracetamolo

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paracetamolo