Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose STARK inner polynomials better #1613

Open
hratoanina opened this issue Aug 12, 2024 · 2 comments
Open

Expose STARK inner polynomials better #1613

hratoanina opened this issue Aug 12, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@hratoanina
Copy link
Contributor

For a given STARK, the way the trace, auxiliary and quotient polynomials are stored is obscure. In particular, the order of auxiliary polynomials in the auxiliary Merkle tree leaves is:

  • Lookup columns
    • Lookup 0
      • Challenge 0
      • Challenge 1
      • ...
    • Lookup 1
    • ...
  • CTL columns
    • CTL helper columns
      • CTL 0
        • Challenge 0
        • Challenge 1
        • ...
      • CTL 1
      • ...
    • CTL Z columns
      • CTL 0
        • Challenge 0
        • Challenge 1
        • ...
      • CTL 1
      • ...

This order is only implied by the relevant helper methods, and it makes it messy to e.g. access only the CTL Z columns. We should at least have this order clearly mentioned somewhere, or an even cleaner way would be to maintain a struct per STARK with the relevant ranges, and implement proper getters out of them.

@hratoanina hratoanina added the enhancement New feature or request label Aug 12, 2024
@mahmudsudo
Copy link

can i take on this ?

@hratoanina
Copy link
Contributor Author

can i take on this ?

Sure, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants