-
Notifications
You must be signed in to change notification settings - Fork 241
Unable to complete market buy orders not completing #22
Comments
Can you expand on this, what behaviour are you expecting? |
Yes, as you can see in the second image there is one buy limit and one sell limit order that has been placed for 0.001 weth and 1 zrx. These orders are not being filled automatically as I would expect. |
@bitstashco this automated matching is not a current feature for the Open Orderbook model. As it crosses a boundary of active participation, an activity some teams desire to avoid. In the real world, the opportunity for profit attracts actors in the ecosystem to match, rather than the operator of Launch Kit. |
I understand, we are simply testing how things work with 0x. The primary issue was that market buys were not going through and giving an error on the initial install. |
As to an update to the issue. I have tested with 0 fees and everything works as expected. For some reason, there are issues when setting a fee amount on kovan for market buy orders. I guess this is a similar issue with the back-end as well as it mentions: Which could be why the order produces an error. I do appreciate your fast response and time helping. |
I'll try and reproduce what you're seeing. Did you deposit ETH into WETH (there's two flows depending if the user has WETH or only ETH)? Were there any fees on the orders? |
Yes I deposited ETH and converted it to WETH I also got ZRX as well. I then split the balances into 3 addresses for testing. Fee address #1 and trading accounts #2 and #3. I have tested on Kovan and Ropsten the error has occurred on both test networks. I set the maker and takers fees to 0.01 ZRX. Everything was left default except for the eth address for fees. Regarding the flows, on Kovan & Ropsten I tested with converted eth (weth) and with eth auto converted to weth for the market buys and it produced the same error. |
As you can see from the below attached screenshot. The error from console. Market sells work as expected. Limit orders also do not match as expected. The only thing currently working as expected is the market sell for orders.
Note: limit orders will stay/show on the exchange however the spread is incorrectly displayed. Please check the second attached image for reference.
Using the Kovan Network on Ubuntu 18.04.2
The text was updated successfully, but these errors were encountered: