Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

db: Make Close safer by automatically tracking ongoing methods. #27

Closed
albrow opened this issue Apr 25, 2019 · 1 comment
Closed

db: Make Close safer by automatically tracking ongoing methods. #27

albrow opened this issue Apr 25, 2019 · 1 comment
Labels
db Issues related to the db package tech debt A code quality issue is not urgent but could cause problems down the line if not addressed

Comments

@albrow
Copy link
Contributor

albrow commented Apr 25, 2019

The documentation for leveldb.DB.Close states:

It is not safe to close a DB until all outstanding iterators are released.

Currently, the onus is on callers to make sure they aren't calling any other methods when calling Close. We could improve usability by tracking this automatically.
@albrow albrow added the db Issues related to the db package label Apr 25, 2019
@albrow albrow mentioned this issue Jun 14, 2019
Open
@albrow albrow added the tech debt A code quality issue is not urgent but could cause problems down the line if not addressed label Jun 19, 2019
@albrow
Copy link
Contributor Author

albrow commented Aug 11, 2020

No longer relevant after the big database upgrade.

@albrow albrow closed this as completed Aug 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
db Issues related to the db package tech debt A code quality issue is not urgent but could cause problems down the line if not addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@albrow