Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce event information #10

Open
duncancmt opened this issue Jul 11, 2023 · 0 comments
Open

Reduce event information #10

duncancmt opened this issue Jul 11, 2023 · 0 comments
Assignees

Comments

@duncancmt
Copy link
Collaborator

// TODO actually calculate the orderHash
emit OtcOrderFilled(
witness, order.maker, taker, order.makerToken, order.takerToken, order.makerAmount, order.takerAmount
);

In keeping with our philosophy of reducing the gas consumed by emitting events, can this event be pruned down to contain just the witness? The witness uniquely identifies the order itself, and the actual fill amounts can be inferred from the Transfer events fired by the 2 tokens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants