Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memory performance tests #292

Closed
mikiw opened this issue Dec 15, 2023 · 7 comments · Fixed by #439
Closed

Add memory performance tests #292

mikiw opened this issue Dec 15, 2023 · 7 comments · Fixed by #439
Assignees
Labels
enhancement New feature or request Hard Task is hard to fix OnlyDust performance testing Related to code testing

Comments

@mikiw
Copy link
Contributor

mikiw commented Dec 15, 2023

It would be nice to have script or memory performance tests to detect memory leaks.

Maybe something similar to crates/starknet-server/tests/test_memory_test.rs in #276

@mikiw
Copy link
Contributor Author

mikiw commented Dec 15, 2023

Related to #272

@ivpavici ivpavici added performance enhancement New feature or request labels Dec 15, 2023
@FabijanC FabijanC added the testing Related to code testing label Dec 20, 2023
@ivpavici ivpavici added ODHack Issue to assign for the ODHack event Hard Task is hard to fix labels Apr 19, 2024
@hhamud
Copy link
Contributor

hhamud commented Apr 22, 2024

@ivpavici can I take this one?

@FabijanC
Copy link
Contributor

@hhamud What is your vision of tackling this? What exactly would you to resolve it?

@hhamud
Copy link
Contributor

hhamud commented Apr 22, 2024

@hhamud What is your vision of tackling this? What exactly would you to resolve it?

Currently to add in memory profiling tools and tests and explore the issue further on. I can see another issue here about the problem of memory leaks. Though I would like to be assigned this issue so I can fully dive in and resolve this specific issue

@FabijanC
Copy link
Contributor

Not sure that's what the issue creator had in mind; can you elaborate @mikiw ?

@ivpavici
Copy link
Contributor

@hhamud good luck!
For the beginning - you can profile the memory and find any potential leaks! Please also check devnet with state archive capacity set to full, there for sure we observe some issues:
https://github.com/0xSpaceShard/starknet-devnet-rs?tab=readme-ov-file#querying-old-state-by-specifying-block-hash-or-number

@mikiw
Copy link
Contributor Author

mikiw commented Apr 23, 2024

I had in mind 2 ways of doing that:

  1. [Harder - requires test and fix of Memory exhaustion  #272] Add test for 10000 invoke transactions (for example minting) and run it with state-archive-capacity full, and measure memory and tweak some numbers like we expect 10000 to have less than 1 GB of RAM or 1000/100mb or something like this. Later after fixing the memory performance problem, the test should pass (TDD approach).
  2. [Easier - just test] Add test for 1000/10000 invoke transactions (for example minting) and test this with 2 modes --state-archive-capacity full and --state-archive-capacity full none. For now, we expect that none test will pass and full will not so for now we can add ignore like this '#[ignore = "Requires fix of performance problem in --state-archive-capacity full mode"]'

I would recommend you @hhamud to go easier way :)

@ivpavici ivpavici removed the ODHack Issue to assign for the ODHack event label May 6, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in starknet-devnet-rs May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hard Task is hard to fix OnlyDust performance testing Related to code testing
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants