-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to hide/ignore specific groups #153
Comments
Not a bad idea, removal could be temporary (does not match) or permanent (WTS/spam groups). However I wonder if the issue could just be solved with a key level filter in the search box. Of course you might have very different ratings for individual dungeons, but isn't there always a key level where you feel comfortable that you would type into the search box? Let's say your best is Algethar +15 and Shadowmoon +18. I claim that you would not search for +16 and "click-remove" Shadowmoon +16. I think you would simply search for +18 as that's what's possible for you and provides the best loot. A problem with this idea is that it would require quite some rewrite of the code, similar to #154. Currently groups are only removed when the list is fetched from the server. Once the list is displayed, PGF does not change it anymore. Another minor issue is that groups do not have a unique ID. So the best identification is the group leader's name, which is not immediately available. |
If ignoring a group is too complex to do, as an alternative, how about ignoring a leader? |
The amount of scam groups is getting absurd, like 60-70% of listings consists of those now, so I really hope there's something that could be done here to weed them out. |
I'm not sure if ignoring leaders is a good way to deal with spam, because spammers can easily create a new or use a different character that's not in your list. Most spammers groups have just one player in the group and/or no rating at all. So if your intention is to remove spam, just set a minimum rio of 1 and a minimum of two players. The intention of this feature is to quickly remove groups that do not match your expectations for whatever reason, not really as spam removal method. When I implement this feature, I'll most likely use the new unique group ID instead of the leader name. This would mean that as soon as the leader recreates the group, it would be displayed again. |
What I'm trying to deal with is not spam, I have 2700 rio set as a minimum and the list is full of
My original idea was to ignore these groups by group ID and then when it looked like that wasn't feasible, I thought of ignoring these people by name, this way they wouldn't pop up again. I don't want to put all of them on full ignore because who knows, maybe tomorrow they will list a legit group that I'm actually interested in and there is no easy way to do so anyway. |
Thanks for clarifying. In this case ignoring the leaders for the duration of the WoW session sounds like a reasonable way to deal with it. |
Yes, that was my thinking exactly. Is there a chance you can implement such a feature? It would be a huge QoL improvement for a lot of people. :) |
I will implement it, but cannot tell you exactly when it will be ready. |
Awesome, thank you! Even knowing that it will be done makes me happy. :) |
Since this (#147) isn't possible, maybe there could be an option to quickly hide specific groups from the dungeon finder. This could be done, for example, by rightclicking the group or some combination like ctrl + rightclick. It can be quick to determine if you don't want to join a group just by looking at it, like when it isn't an upgrade for you.
There could probably also be an option to reset these hidden groups.
The text was updated successfully, but these errors were encountered: