Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The output is different between window and mac #67

Open
minhquankq opened this issue Aug 17, 2020 · 5 comments
Open

The output is different between window and mac #67

minhquankq opened this issue Aug 17, 2020 · 5 comments

Comments

@minhquankq
Copy link

I have optimized image from the same image and execute on window and mac
Input image 87kb

Output:

  • Window image 30.8 kb
  • Mac image 32 kb

Expected: the output should be the same.

@1000ch
Copy link
Owner

1000ch commented Aug 17, 2020

If you are using the same version of gulp-image and its configuration, the results should be the same as you say. Is there any difference between those configurations? or if they are same, the binaries bundled on gulp-image might (?) be different. So, could you clarify the difference between them?

@minhquankq
Copy link
Author

minhquankq commented Aug 18, 2020

I use the same version (6.1.0) and configuration

const imageOptimizerOptions = {
  pngquant: true,
  optipng: false,
  zopflipng: true,
  jpegRecompress: false,
  mozjpeg: true,
  guetzli: false,
  gifsicle: true,
  svgo: ['--enable', 'cleanupIDs', '--disable', 'convertColors', '--disable', 'removeViewBox'],
  concurrent: 10,
  quiet: true, // defaults to false
};

my gulp tasks are download the images from another repository and gulp-image to optimize the download images. if run again, I will delete the optimized images and download and gulp-image again (to make sure the input of gulp-image will be the same).

  • first, I run these gulp tasks on window, then commit the optimized images to git repository.
  • second, my teammate runs the same task on mac.

=> the expected is git status should not list any change

but currently, the optimize images was changes (they are different size also), does it depend on OS?

I have checked the version (the image for testing is jpeg)

  • gulp-image 6.2.0
  • mozjpeg 7.0.0
  • jpeg-recompress-bin 5.1.0
    The same version for window and mac.

@1000ch
Copy link
Owner

1000ch commented Aug 20, 2020

Also, would you check the version of binaries in node_modules?

@minhquankq
Copy link
Author

Sorry for the late response, but what do you mean for binaries in node_modules? in my node_modules doesn't have any binaries dependency
image

@1000ch
Copy link
Owner

1000ch commented Aug 24, 2020

I mean the binaries bundled by each package (mozjpeg, jpeg-recompress-bin) in gulp-image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants