Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onReadOnlyChecked in TaskListBridge (TaskItem) #131

Closed
jinwon7878 opened this issue Jun 12, 2024 · 1 comment
Closed

onReadOnlyChecked in TaskListBridge (TaskItem) #131

jinwon7878 opened this issue Jun 12, 2024 · 1 comment

Comments

@jinwon7878
Copy link

jinwon7878 commented Jun 12, 2024

Hi! I'm having a great time implementing your editor, and thank you for always being so quick to respond.

I'd like to pass onReadOnlyChecked to configure, so that the TaskItem can be checked when the editor is used with editable : false. This could be a key feature for my project, as it would definitely make the “check” function more usable for users.

https://tiptap.dev/docs/editor/api/nodes/task-item#on-read-only-checked

Currently, passing it to configureExtension of TaskListBridge doesn't seem to be supported (is it because onReadOnlyChecked is the configure attribute of TaskItem?), so I'm wondering if this is something I'd need to work around personally with an advanced setup, or if there's an update planned?

Thanks as always :)

@GuySerfaty
Copy link
Contributor

Hi, @jinwon7878 again! love to hear you have a great time with 10tap, unfortunately, I think even with adding onReadOnlyChecked functionality you wouldn't be able to know which task item changed because of this issue, Im open to add onReadOnlyChecked if you have a good way to "know" which node changed, it can be an important improvement to our lib

@17Amir17 17Amir17 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants