Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Add back term_suggest to search queries #2346

Closed
felipeelia opened this issue Sep 13, 2021 · 1 comment · Fixed by #2347
Closed

BUG: Add back term_suggest to search queries #2346

felipeelia opened this issue Sep 13, 2021 · 1 comment · Fixed by #2347
Assignees
@felipeelia
Labels
confirmed bug high priority
Milestone
3.6.3

Comments

@felipeelia
Copy link
Member

Describe the bug

Although we index a field called "term_suggest" it's not been used. We should include it back in autosuggest search queries.

Steps to Reproduce

  1. Make an autosuggest search
  2. Check that each document in results has a "term_suggest" property
  3. Note that field is not used in the search query

Expected behavior
That field should/could be used in autosuggest searches.

Additional context
We already add a field called post_title.suggest in autosuggest here.
@felipeelia felipeelia added the bug Something isn't working label Sep 13, 2021
@felipeelia felipeelia added this to the 3.6.3 milestone Sep 13, 2021
@felipeelia felipeelia added confirmed bug high priority and removed bug Something isn't working labels Sep 13, 2021
@felipeelia felipeelia self-assigned this Sep 13, 2021
@felipeelia
Copy link
Member Author

As different taxonomies may have different weights, for 3.6.3 let's add that field always with weight = 1.

@felipeelia felipeelia mentioned this issue Sep 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipeelia felipeelia

Labels
confirmed bug high priority
Projects
None yet
Milestone
3.6.3
Development

Successfully merging a pull request may close this issue.

Autosuggest: Major rewrite of adjust_fuzzy_fields 10up/ElasticPress
1 participant
@felipeelia