Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: as an admin user, every page load in the dashboard results in a "get mapping" call #2432

Closed
dustinrue opened this issue Oct 31, 2021 · 0 comments · Fixed by #2445
Closed
Assignees
Labels
bug Something isn't working high priority
Milestone

Comments

@dustinrue
Copy link
Contributor

Describe the bug

If you are a full admin user, then every page load within the admin dashboard results in a remote call to Elasticsearch to fetch the mapping. This adds a significant amount of time to each page load.

Steps to Reproduce

  1. Be a user with the Administrator role
  2. Enable the plugin
  3. Browse the admin
  4. Suffer with longer page loads

Expected behavior

The mapping currently installed vs what is expected probably won't change often or ever until a plugin update is performed.

My suggestion is to rewrite notices routines so they happen on wp-cron rather than inline with page requests. Use transients to store the results of the checks and display noticed based on what the transient says. Cache this information and don't refresh it unless necessary.

@dustinrue dustinrue added the bug Something isn't working label Oct 31, 2021
@brandwaffle brandwaffle added this to the 4.0.0 milestone Nov 2, 2021
@felipeelia felipeelia modified the milestones: 4.0.0, 3.6.5 Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants