Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Hide last sync element info box if there's no info to display #2695

Closed
Tracked by #2704
oscarssanchez opened this issue Mar 31, 2022 · 1 comment · Fixed by #2858
Closed
Tracked by #2704

BUG: Hide last sync element info box if there's no info to display #2695

oscarssanchez opened this issue Mar 31, 2022 · 1 comment · Fixed by #2858
Assignees
@felipeelia
Labels
bug Something isn't working module:sync Issues related to the Sync functionality
Milestone
4.3.0

Comments

@oscarssanchez
Copy link
Contributor

Describe the bug

When you don't have info to display, the box is still shown:

Screen Shot 2022-03-31 at 12 17 53

Steps to Reproduce

  1. Fresh install of EP
  2. Go to sync page
  3. See box empty

Expected behavior

The box should not be shown.
@oscarssanchez oscarssanchez added the bug Something isn't working label Mar 31, 2022
@felipeelia
Copy link
Member

We could go a bit further here and check if the needed indices already exist. If they don't, the "Full Sync" would need to be the only option available.

@felipeelia felipeelia added the module:sync Issues related to the Sync functionality label Mar 31, 2022
@felipeelia felipeelia mentioned this issue Apr 8, 2022
Closed
6 tasks
@felipeelia felipeelia mentioned this issue Jun 20, 2022
Closed
@felipeelia felipeelia added this to the 4.3.0 milestone Jun 20, 2022
@JakePT JakePT mentioned this issue Jun 24, 2022
Merged
6 tasks
@felipeelia felipeelia assigned JakePT and unassigned JakePT Jul 19, 2022
@JakePT JakePT assigned felipeelia and unassigned JakePT Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipeelia felipeelia

Labels
bug Something isn't working module:sync Issues related to the Sync functionality
Projects
None yet
Milestone
4.3.0
Development

Successfully merging a pull request may close this issue.

Show a single sync option for the initial sync. 10up/ElasticPress
3 participants
@felipeelia @JakePT @oscarssanchez