Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Users can modify settings during a sync if the Features or Settings page was already open #2795

Closed
JakePT opened this issue May 24, 2022 · 0 comments · Fixed by #2823
Closed
Assignees
Labels
bug Something isn't working module:sync Issues related to the Sync functionality
Milestone

Comments

@JakePT
Copy link
Contributor

JakePT commented May 24, 2022

Describe the bug
Normally during a full delete and sync the Features and Settings pages are disabled to prevent changing settings, enabling or disabling features, or modifying feature settings during this process. However if the use opens the either page in before syncing, and keeps it open while starting a delete and sync in another tab, they will be able to make those changes while the sync is occurring.

Steps to Reproduce

  1. Open the Sync page.
  2. Press Delete all Data and Start a Fresh Sync.
  3. While this is happening open the Features page in the same tab. It should be greyed out and disabled.
  4. Once finished, open the Sync page again.
  5. Then open the Features page in a new tab.
  6. Switch back to the Sync page and press Delete all Data and Start a Fresh Sync.
  7. While it is syncing switch to the other tab with the Features page open. It won't be disabled and it will be possible to modify and save settings.

Repeat for the Settings page. The behaviour will be the same.

Expected behaviour
Saving Feature settings while a sync is occurring should fail, and an error message displayed. Ideally at this time the relevant page should become disabled to match its behaviour when it's opened during a sync.

@JakePT JakePT added the bug Something isn't working label May 24, 2022
@felipeelia felipeelia added the module:sync Issues related to the Sync functionality label May 24, 2022
@felipeelia felipeelia added this to the 4.3.0 milestone May 24, 2022
@felipeelia felipeelia modified the milestones: 4.3.0, 4.2.1 Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module:sync Issues related to the Sync functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants