Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to do more configuration in admin #7

Closed
AaronHolbrook opened this issue Jun 10, 2014 · 3 comments
Closed

Add ability to do more configuration in admin #7

AaronHolbrook opened this issue Jun 10, 2014 · 3 comments

Comments

@AaronHolbrook
Copy link
Contributor

Things like index name, meta fields to index, etc

@tlovett1
Copy link
Member

We have index name. Right now, non-protected meta fields are indexed. I think that is sufficient. Although an extra filter couldn't hurt.

@AaronHolbrook
Copy link
Contributor Author

Sorry - was porting over some ideas from the old repo.

Are you auto-indexing all meta fields? We dealt with that at the hack day to ensure that we only include explicitly declared meta fields.

Aaron Holbrook
Web Engineer, 10up
(815) 293-7189 · @aaronjholbrook

On Jun 10, 2014, at 3:15 PM, Taylor Lovett notifications@github.com wrote:

We have index name. Right now, non-protected meta fields are indexed. I think that is sufficient. Although an extra filter couldn't hurt.


Reply to this email directly or view it on GitHub.

@tlovett1
Copy link
Member

We are indexing non-protected meta fields. See is_protected_meta() function also register_meta(). We actually need to check for an authorization callback before checking whether the meta is protected. We went through all this with WP API last week. In short, a filter is not necessary WP has functionality built-in to determine whether meta is public or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants