Skip to content
This repository has been archived by the owner on Mar 14, 2020. It is now read-only.

Update generated gitignore file #93

Open
timwright12 opened this issue Oct 4, 2016 · 3 comments
Open

Update generated gitignore file #93

timwright12 opened this issue Oct 4, 2016 · 3 comments
Assignees

Comments

@timwright12
Copy link

timwright12 commented Oct 4, 2016

Can we update the generated gitignore file with some more standard additions? Suggestion:

/release/
/vendor/
composer.lock
phpunit.xml
.idea

# Sass
.sass-cache
*.map

# NPM
node_modules/

# Editors
*.esproj
*.tmproj
*.tmproject
tmtags
.*.sw[a-z]
*.un~
Session.vim
*.swp

# Mac OSX
.DS_Store
._*
.Spotlight-V100
.Trashes

# Windows
Thumbs.db
Desktop.ini
@cmmarslender
Copy link

I'm particularly a fan of the more specific /vendor/ and /release/ so we don't accidentally ignore a folder called vendor inside of say, a "sass" folder 👍

@cmmarslender
Copy link

Before we merge this, we should remove the ignore on the composer.lock file - want to make sure we are able to deploy known composer dependencies, and need that file to do so.

@lkwdwrd
Copy link
Contributor

lkwdwrd commented Oct 4, 2016

Agree with this idea -- The general team is pushing to get the V1 rewrite done, which will include these. We're trying not to make many changes to the legacy version at this point, but the plan is to look closely at the files output after build, including the .gitignore, which yes, should really not have the composer.lock file in it amongst the other things mentioned here.

I'll leave this issue open for anyone wanting to write up the PR, or as a reminder as we finish out version 1. if we push version 1 before a PR comes through I'll close as wontfix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants