Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Cypress to version 13 #347

Closed
1 of 4 tasks
iamdharmesh opened this issue Sep 1, 2023 · 2 comments · Fixed by #349
Closed
1 of 4 tasks

Upgrade Cypress to version 13 #347

iamdharmesh opened this issue Sep 1, 2023 · 2 comments · Fixed by #349
Assignees
Labels
help wanted type:enhancement New feature or request.
Milestone

Comments

@iamdharmesh
Copy link
Member

Is your enhancement related to a problem? Please describe.

Cypress 13 was recently released, and Cypress 12 contains some breaking changes as listed below. We need to update our tests to make them work with the latest version and fix any issues that may arise.

  • Upgrade cypress to 13.0.0 (or latest version at the time of working on this)
  • Upgrade @10up/cypress-wp-utils to 0.2.0
  • Replace legacy API usage such as Cookies.defaults with the new replacements.

Breaking changes we need to be aware of

  • Cypress dropped support for Node.js 12
  • In Cypress 12, we enforce running tests in a clean browser context through test isolation.
  • The Cookies.defaults and Cookies.preserveOnce APIs have been removed. Use the new cy.session() command to preserve cookies between tests.

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@iamdharmesh iamdharmesh added type:enhancement New feature or request. help wanted labels Sep 1, 2023
@iamdharmesh iamdharmesh added this to the Future Release milestone Sep 1, 2023
@dkotter
Copy link
Collaborator

dkotter commented Sep 7, 2023

Note that our E2E tests are failing right now due to the need to upgrade Cypress.

Our @10up/cypress-wp-utils package is used here but we don't load a versioned release, we load from the build branch. This loads the latest version which runs on a newer version of Cypress and conflicts with the version of Cypress we are using. So this is an ideal task for someone to pick up as it helps get our tests running properly again.

@iamdharmesh iamdharmesh self-assigned this Sep 8, 2023
@iamdharmesh iamdharmesh mentioned this issue Sep 8, 2023
4 tasks
@iamdharmesh
Copy link
Member Author

Tests are failing due to Cypress 13 upgrade in #343, as e2e tests still using removed cookies API. Raised #349 to fix this.

@jeffpaul jeffpaul modified the milestones: Future Release, 2.2.0 Sep 8, 2023
@dkotter dkotter modified the milestones: 2.2.0, 2.1.1 Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted type:enhancement New feature or request.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants