Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation error #22

Closed
ghost opened this issue Nov 22, 2022 · 2 comments
Closed

Deprecation error #22

ghost opened this issue Nov 22, 2022 · 2 comments
Labels
resolution:resolved This issue has been resolved. type:bug Something isn't working.
Milestone

Comments

@ghost
Copy link

ghost commented Nov 22, 2022

Describe the bug

Here's my yml:

name: WordPress Coding Standards checks

on: push

jobs:
  phpcs:
      name: WPCS
      runs-on: ubuntu-latest
      steps:
        - uses: actions/checkout@v2
        - name: WPCS check
          uses: 10up/wpcs-action@stable

This action is giving error:
<error line="1" column="1" severity="error" message="An error occurred during processing; checking has been aborted. The error message was: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /github/home/wpcs/WordPress/Sniffs/WP/I18nSniff.php on line 194" source="Internal.Exception"/>

Screenshot_1

I tried running the sniffer using older versions of PHP (7.2 and 7.4) with no luck. shivammathur/setup-php@v2 was used to switch PHP version in yml file.

The sniffer was working fine about 2-3 months ago.

Steps to Reproduce

  1. Add workflow config in .yml file
  2. Push test changes
  3. Error!
@ghost ghost added the type:bug Something isn't working. label Nov 22, 2022
@peterwilsoncc
Copy link

Thanks for the report @azamat-bs

This has been fixed in pull request #20 and will be included in the next release.

You can be notified of the next release via the "watch" dropdown at the top of this page. You can select "custom" and check the releases option to be notified only of releases.

The team is aiming to get a release out soon as this is affecting a number of people but we don't have an exact ETA at the moment.

Thanks again for getting in touch.

@vikrampm1 vikrampm1 moved this to Incoming in Open Source Practice Nov 23, 2022
@peterwilsoncc peterwilsoncc added this to the 1.4.0 milestone Nov 23, 2022
@peterwilsoncc peterwilsoncc added the resolution:resolved This issue has been resolved. label Nov 23, 2022
@peterwilsoncc
Copy link

A new release, version 1.4.0, has been tagged to fix this issue.

I'll close this issue as resolved.

Repository owner moved this from Incoming to Merged in Open Source Practice Nov 23, 2022
@vikrampm1 vikrampm1 moved this from Merged to Done/Released in Open Source Practice Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:resolved This issue has been resolved. type:bug Something isn't working.
Projects
Archived in project
Development

No branches or pull requests

1 participant