-
-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensionless layout in 2.0 canary 20 #2704
Comments
See #2700 |
Whew, a few more of these and I will revert the default 😅 |
Thanks! I missed that. |
@zachleat, I think there just needs to be a really clear notice, since it's a potentially breaking change. Maybe a clearer error message like "It looks like the layout file you specified is missing a file extension." If memory serves, previous documentation made it sound like omitting the file extension was a preferable, nifty feature, to promote Eleventy's flexible templating language options. I agree that specifying an extension is a significant performance improvement. If there is a default that can forego specification, it should be |
@zachleat What about reverting the build error and seeing if we can flag it as a noisy warning in https://github.com/11ty/eleventy-upgrade-help and possibly say we'll change the default behavior in 2.1 or 3.0. Not sure if we need to add that eleventy-upgrade-help plugin to the https://www.11ty.dev/docs/ sidebar to increase visibility (since I knew about it, but still took some googling to find it). |
Restoring this in #2708! This is more popular than I thought 😅 |
I do like the change to require the extension, and I agree that a more clear error message explaining that the file extension is missing would make it easier. I mean that's the point of a canary/alpha release is that there will be API-breaking changes as the design is iterated on. |
Operating system
macOS
Eleventy
2.0.0-canary.20
Describe the bug
I'm using liquid layout names without extension.
Just updated to canary 20 and got this error:
Reproduction steps
No response
Expected behavior
No response
Reproduction URL
No response
Screenshots
No response
The text was updated successfully, but these errors were encountered: