Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal logging for tock is needed #1117

Closed
6 tasks
cryptofilegsa opened this issue Jun 19, 2020 · 1 comment
Closed
6 tasks

internal logging for tock is needed #1117

cryptofilegsa opened this issue Jun 19, 2020 · 1 comment

Comments

@cryptofilegsa
Copy link
Contributor

cryptofilegsa commented Jun 19, 2020

If tock will be used as a system of record for time recording, or to provide billing information to clients, not only is timecard accuracy important, but also a log of changes to timecards, by any user including admins, since multiple users can access a user's timecard for additions, modifications and deletions.  

All timecard modifications should be logged with timestamp in a way that identifies the modifying user and the user of the timecard being modified, along with specifics of the timecard change: number of hours added, number of hours removed, and the codes to which all hours modified are associated.  For consistency and integrity, logging would need to be implemented and enforced around any interface for mass modification of multiple timecards as well.

Similar work: timecard modification / change requests are currently being managed by means of google form.

We'll know we're done when

  • all individual timecard modifications are logged
  • log entries include:
  • name of modifier
  • date range of timecard being modified (key for timecard)
  • name of timecard owner
  • timestamp of modification
  • number of hours being added, changed, or deleted
  • associated billing code for the change
  • mass modifications of timecards are also logged
  • timecard logs are in a reviewable form, not buried in HTTP traffic logs for instance
  • log data is written in an enforceable write-only mode, not modifiable by users including admins
  • logging has verifiable non-repudiation

Without this necessary feature, alternatives for tock logging should be explored thoroughly.

History of related (but not the same) issues involving audit, admins, and logging:
#418
#822
#924

@Jkrzy
Copy link
Contributor

Jkrzy commented Aug 7, 2020

Tock, Django, and cloud.gov provide the logging necessary for our purposes per our system security plan

@Jkrzy Jkrzy closed this as completed Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants