Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exiting with Ctrl+C causes the terminal cursor to become invisible #14

Open
OpenSauce04 opened this issue Nov 5, 2024 · 1 comment
Open

Comments

@OpenSauce04
Copy link

OpenSauce04 commented Nov 5, 2024

While I'm aware that there is a "correct" shortcut to exit the program, that being the Q key, it's difficult to break the muscle memory of using Ctrl+C to exit a program. For this reason I believe that this issue should be addressed.

Here is an image illustrating the issue:
Before running:
image
After exiting with Ctrl+C:
image
After exiting with Q:
image

I am using Wezterm in the above screenshots, although I would assume that this issue happens across most terminals.

@18alantom
Copy link
Owner

18alantom commented Dec 22, 2024

This was initially added (by turning off ISIG) but removed later cause you want to be able to terminate fex if it's taking too long.

For example: if you if you press E (expand all folders) and then G (jump to the bottom), when say pwd is /, fex will take some time to reach the bottom.

If Ctrl-C is handled by fex for a clean exit, it won't do anything in the duration that it takes to reach the bottom.

This has to do with fex being single threaded. Rendering and input handling are done in the same thread (unlike say fzf).

Handling Ctrl-C cleanly and responsively requires input handling to be on a separate thread. This is something that I want to do, but don't know when I'll get to.


A way to get around Ctrl-C causing cursor disappearance is to use reset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants