Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret injector deployment incorrectly marked as hook #150

Open
alexnederlof opened this issue May 30, 2023 · 0 comments
Open

Secret injector deployment incorrectly marked as hook #150

alexnederlof opened this issue May 30, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@alexnederlof
Copy link

Your environment

Chart Version: latest

Helm Version: latest

Kubernetes Version: 1.26

What happened?

The helm deploy is stuck, because the deployment is marked as a hook here: https://github.com/1Password/connect-helm-charts/blob/main/charts/secrets-injector/templates/deployment.yaml#L10

But since the hook never completes (because it's a deployment), the deploy never completes and helm gets stuck.

Removing the hook annotation fixes it.

What did you expect to happen?

The helm chart to work

Steps to reproduce

Try deploying the helm chart. I did it through Argo. It times out on waiting for the hook to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant