Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for annotations of individual resources #145

Open
chauncey-garrett opened this issue Aug 22, 2024 · 0 comments
Open

Allow for annotations of individual resources #145

chauncey-garrett opened this issue Aug 22, 2024 · 0 comments

Comments

@chauncey-garrett
Copy link

Summary

We need the capability to individually annotate the Service resource.

Use cases

In our particular use case, we need to provide the following annotation on the Service resource:

  annotations:
    cloud.google.com/neg: '{"ingress":true}'

This annotation is automatically added by GKE. Since we use Gitops and the annotation doesn't exist, Argo CD sees the resource as being perpetually out of sync.

Another use case would be to add appropriate Workload Identity annotations to a SA.

Proposed solution

While the capability to add annotations to all resources currently exists through .Values.scim.annotations, the chart should allow annotations on each individual k8s resource (e.g., Service, Deployment, etc.).

Is there a workaround to accomplish this today?

No, not without using kustomize.

References and prior work

For example, https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/values.yaml allows annotations on individual resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant