Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate plugin and executable #128

Open
osiegmar opened this issue Dec 24, 2022 · 1 comment
Open

Separate plugin and executable #128

osiegmar opened this issue Dec 24, 2022 · 1 comment
Labels
op-cli Functionality to be implemented in 1Password CLI. Needs to be done by 1Password Developers.

Comments

@osiegmar
Copy link

osiegmar commented Dec 24, 2022

op CLI version

2.12.0

Goal or desired behavior

It would be great being able to use plugins with configurable executables.

I'm using Terraform in an AWS environment for example. I'd like to use the aws plugin to authenticate when using Terraform.

Maybe a new flag can be introduced:

alias aws="op plugin run -- aws"
alias terraform="op plugin run --exec /usr/bin/terraform -- aws"

That should also help on #120

Additional safety measures are required to protect malicious misuse. Somebody could enter to an open terminal session:

alias aws="op plugin run --exec /tmp/evil_aws_credential_sniffer -- aws"

Maybe a configurable whitelist for valid executables?

Merry Christmas! 🎅

Current behavior

Currently I'm using https://github.com/broamski/aws-mfa which unfortunately lacks 1Password support for obtaining the MFA token.

Relevant log output

No response

@osiegmar osiegmar added the op-cli Functionality to be implemented in 1Password CLI. Needs to be done by 1Password Developers. label Dec 24, 2022
@SimonBarendse
Copy link
Member

@scottlamb shared a similar use case in #180 (comment):

The biggest problem I see with this plugin is something else entirely: AFAICT it only runs aws commands, when really there are tons of other programs that use ~/.aws, including e.g. npx aws-cdk and whatever else is written with AWS SDKs. Those don't get the STS provisioner's environment variables, and so setting up ~/.aws to require that environment means they don't work (unless I supply a similar environment by hand / in some other way when invoking them). That's a deal-breaker. I need an easy way to invoke arbitrary commands in this same environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
op-cli Functionality to be implemented in 1Password CLI. Needs to be done by 1Password Developers.
Projects
None yet
Development

No branches or pull requests

2 participants