Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: allow onepassword_item resource to be created without a password #66

Open
MarshallAsch opened this issue Jul 5, 2022 · 1 comment

Comments

@MarshallAsch
Copy link

Summary

Allow some way for the password field to be left blank during resource creation.

Use cases

For some password entries it is not desirable to have a password field. (for example AWS IAM access keys, a better format may be to use something like the following (created through the 1password website) where the secrets are stored in additional fields that can be named appropriately.

image

However, when using the the Terraform resource leaving out the password parameter leads to the generation of a new random password which may not be desirable. (explicitly setting it to an empty string has the same result).

Proposed solution

In order to maintain backwards compatibility a null, or "" password must continue to generate a new random password.
Instead, the password_recipe.length parameter can be modified to allow a password length of 0, or a new password_recipe.generate = False to be specified to disable the generation of random passwords.

Is there a workaround to accomplish this today?

As far as I can tell there is no way to not include the password field in any resources generated by Terrafrom. The closest I have been able to get is to set the password to a clearly non password value of not a real password.

References & Prior Work

@hangpark
Copy link

hangpark commented Jul 25, 2022

I need this feature too. For backward compatibility, what about introducing allow_empty_password field on the schema? In this case set up, if there is neither a password nor a password recipe in the tf configuration, disabling password generating would be good enough I think. Of course, @MarshallAsch's proposal sounds good, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants