Gmpy2 causes installation issues downstream

[ajdapretnar]

#44 introduces gmpy2 dependency, which causes major issues downstream. Error:
src/gmpy.h:252:20: fatal error: mpfr.h: No such file or directory
gmpy2 doesn't seem to be pip installable, at least not on OSX.

[1e0ng]

@bebound Could you help take a look?

[bebound]

I'm using macOS, and I have no issue installing gmpy2
Some said it can be installed following these steps, can you check this please? @ajdapretnar

brew install gmp
brew install mpfr
brew install libmpc
pip install gmpy2

[ajdapretnar]

Perhaps, but in our project we can't be brew-installing additional dependencies on users' systems. 😞 It's only pip and/or conda we can use. I am on High Sierra 10.13.6. I'll ask my colleagues to try the same and see if they experience the same problem.

[ajdapretnar]

I have asked them and those that don't have many build utilities installed weren't able to install it. Those that do - no problem. I think a solution would be to provide a Mac build.

[bebound]

gmpy2 depend on these computation library, so these library need to be installed when python tries to compile and install the package.

wheel should be able so solve this problem. https://github.com/pypa/manylinux. Maybe we can provide the wheel format package.

[bebound]

Which python are you using? I'm trying to build a wheel, can you help test whether it works?

[1e0ng]

I just now uploaded wheel packages for the most recent version 1.10.1 https://pypi.org/project/simhash/1.10.1/#files
Can you try if it works? @ajdapretnar Thanks.

[ajdapretnar]

I am using Py3.8 and Py3.6. I've tried it and it doesn't work. 😞 I appreciate your effort!

[bebound]

Seems we can only pre-compile this project's C dependencies with wheel.

gmpy2 only provides wheel for windows, and Conda provide gmpy2 package.
pip user has to install these package manually:

apt-get install libgmp-dev
apt-get install libmpfr-dev
apt-get install libmpc-dev

aleaxit/gmpy#227

[bebound]

I built a gmpy2 wheel, can you check if this works?
Change the suffix from zip to whl, and python3.6 -m pip install gmpy2-2.1.0b5-cp36-cp36m-manylinux2014_x86_64.whl.

gmpy2-2.1.0b5-cp36-cp36m-manylinux2014_x86_64.zip

[ajdapretnar]

I tried, but this seems like a Linux wheel and I am on OSX. Anyhow, it reports wheel not supported on this platform.

[bebound]

@ajdapretnar How about this one?

gmpy2-2.1.0b5-cp36-cp36m-macosx_10_9_x86_64.zip

gmpy2-2.1.0b5-cp38-cp38-macosx_10_9_x86_64.zip

[1e0ng]

@bebound I'll revert the change of GMP first. Let's find a way to resolve this thoroughly later.

[bebound]

Okay, I’ve found a way to build wheel for gmpy, I’ll create a PR later.

…

On May 1, 2020, 12:48 +0800, Leon ***@***.***>, wrote: @bebound I'll revert the change of GMP first. Let's find a way to resolve this thoroughly later. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[ajdapretnar]

Yes, it works. 🙌

[bebound]

Glad to know this. I’ve opened this issue on gmpy: aleaxit/gmpy#274

…

On May 2, 2020, 02:08 +0800, Ajda ***@***.***>, wrote: Yes, it works. 🙌 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[1e0ng]

Hi @bebound I see your pull request has been merged, so just curious, any plan on this? 😄

[bebound]

The wheels can be found here: https://github.com/aleaxit/gmpy/actions/runs/97828599, but this has not been uploaded to pypi.

PS: It seems the maintainer has trouble with windows pip install.

[slel]

in our project we can't be brew-installing additional dependencies
on users' systems. It's only pip and/or conda we can use.

One can conda install gmpy2 via the conda-forge channel.

• https://github.com/conda-forge/gmpy2-feedstock/

[bebound]

gmpy has wheels on pypi now, would you like to use gmpy2 now? @1e0ng

[1e0ng]

Sure, @bebound would you like to create a pull request?

[bebound]

Okay.

[bebound]

I found there is no wheels for MacBook with Apple Silicon. I'll make the wheel first and create PR later.

[bebound]

I've create #67