Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] : Setup : The button to clear all candidates does not work when tapping on a laptop touchpad #78

Open
V-ed opened this issue Jan 20, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@V-ed
Copy link
Member

V-ed commented Jan 20, 2020

The button to clear all candidates simply does not work.

It might be an issue of focus being removed from the popup but I am not sure.

I am now unsure if the same popup works for the skip shared election function... I'll test it out and update this issue if so.

Code lens : https://github.com/V-ed/Scouts-Elections/blob/eba9d738289e9bae26bc691a56f3f2d2bac7f83e/js/setup.js#L175-L219

The issue stems from laptop touches that are probably treated differently than regular mouse clicks / touches.

I have no idea how this can be fixed. Maybe changing how I handle the popup display (instead of doing it via the focus of the "remove all candidates", do it manually?) would work? Dunno, it's something to look into.

The button to confirm does work, but not with a laptop's tap input on the trackpad. It does work however on a laptop when using a physical button.

I'll confirm this on my own laptop. Maybe different manufacturers use different touchpad technologies, and it would be better to use a system that works for everything.

Confirmed to also not work on my own laptop. Very interesting, I'll see how a touchpad tap is different than a click!

@V-ed V-ed added the bug Something isn't working label Jan 20, 2020
@V-ed V-ed changed the title [BUG] : Setup : The button to clear all candidates names does not work [BUG] : Setup : The button to clear all candidates does not work when tapping on a laptop touchpad Jan 20, 2020
@V-ed V-ed self-assigned this Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants