Skip to content

Commit e25743b

Browse files
authored
Update dependencies to support Django 4.2 (#27)
1 parent 12255f2 commit e25743b

File tree

8 files changed

+2
-34
lines changed

8 files changed

+2
-34
lines changed

src/django_handleref/admin.py

+1-14
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@
33
import traceback
44

55
from django import forms
6-
from django.conf.urls import re_path
76
from django.contrib import admin
87
from django.contrib.admin.views.main import ChangeList
98
from django.core.exceptions import ValidationError
109
from django.shortcuts import redirect
1110
from django.template.response import TemplateResponse
11+
from django.urls import re_path
1212
from django.utils.translation import gettext_lazy as _
1313

1414
# soft import reversion - since it is not a hard
@@ -123,7 +123,6 @@ def history_query_set(self, object_id):
123123
return history_qset
124124

125125
def history_entry(self, version, previous):
126-
127126
"""
128127
Compile object history list entry dict
129128
@@ -186,7 +185,6 @@ def history(self, history_qset):
186185
return history
187186

188187
def history_view(self, request, object_id):
189-
190188
"""
191189
object history view
192190
"""
@@ -225,7 +223,6 @@ def history_view(self, request, object_id):
225223
return super().history_view(request, object_id, context)
226224

227225
def version_details_view(self, request, object_id, version_id, extra_context=None):
228-
229226
"""
230227
Show version details
231228
"""
@@ -251,7 +248,6 @@ def version_details_view(self, request, object_id, version_id, extra_context=Non
251248
return TemplateResponse(request, self.version_details_template, context)
252249

253250
def version_revert_view(self, request, object_id, extra_context=None):
254-
255251
"""
256252
Show version revert preview / confiformation view
257253
"""
@@ -286,7 +282,6 @@ def version_revert_view(self, request, object_id, extra_context=None):
286282
return TemplateResponse(request, self.version_revert_template, context)
287283

288284
def version_revert_process(self, request, object_id, extra_context=None):
289-
290285
"""
291286
Process revert version(s)
292287
"""
@@ -312,21 +307,18 @@ def version_revert_process(self, request, object_id, extra_context=None):
312307

313308
errors = {}
314309
try:
315-
316310
# revert
317311

318312
reverter = self.reverter_cls()
319313
instance = self.model.objects.get(pk=object_id)
320314
reverter.revert_fields(instance, field_versions, user=request.user)
321315

322316
except ValidationError as exc:
323-
324317
# validation errors are collected
325318

326319
errors = exc.message_dict
327320

328321
except Exception as exc:
329-
330322
# any other errors are logged
331323

332324
errors = {"non_field_errors": ["Internal Error (check server logs)"]}
@@ -352,7 +344,6 @@ def version_revert_process(self, request, object_id, extra_context=None):
352344
)
353345

354346
def version_rollback_view(self, request, object_id, version_id, extra_context=None):
355-
356347
"""
357348
Version rollback preview / confirmation view
358349
"""
@@ -377,7 +368,6 @@ def version_rollback_view(self, request, object_id, version_id, extra_context=No
377368
def version_rollback_process(
378369
self, request, object_id, version_id, extra_context=None
379370
):
380-
381371
"""
382372
Version rollback process
383373
"""
@@ -391,21 +381,18 @@ def version_rollback_process(
391381

392382
errors = {}
393383
try:
394-
395384
# rollback
396385

397386
reverter = self.reverter_cls()
398387
instance = self.model.objects.get(pk=object_id)
399388
reverter.rollback(instance, version, user=request.user)
400389

401390
except ValidationError as exc:
402-
403391
# collect validation errors
404392

405393
errors = exc.message_dict
406394

407395
except Exception as exc:
408-
409396
# log any other errors
410397

411398
errors = {"non_field_errors": ["Internal Error (check server logs)"]}

src/django_handleref/manager.py

-4
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ def since(self, timestamp=None, version=None, deleted=False):
4747
qset = self
4848

4949
if timestamp is not None:
50-
5150
if isinstance(timestamp, numbers.Real):
5251
timestamp = datetime.datetime.fromtimestamp(timestamp)
5352

@@ -56,17 +55,14 @@ def since(self, timestamp=None, version=None, deleted=False):
5655
)
5756

5857
if version is not None:
59-
6058
qset = qset.filter(version__gt=version)
6159

6260
if not deleted:
63-
6461
qset = qset.undeleted()
6562

6663
return qset
6764

6865
def undeleted(self):
69-
7066
"""
7167
Only return objects that are not soft-deleted
7268
"""

src/django_handleref/models.py

-1
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@ def __unicode__(self):
119119
return name + "-" + self.handle
120120

121121
def delete(self, hard=False):
122-
123122
"""
124123
Override the vanilla delete functionality to soft-delete
125124
instead. Soft-delete is accomplished by setting the

src/django_handleref/version.py

-10
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ class Version:
1515
"""
1616

1717
def __init__(self, version):
18-
1918
"""
2019
Argument(s):
2120
@@ -154,7 +153,6 @@ def changes(self, previous):
154153
return Diff(previous, self).changes
155154

156155
def changed_fields(self, previous):
157-
158156
"""
159157
Return a list of changed fields between
160158
this version and a previous version
@@ -333,7 +331,6 @@ class Diff:
333331
]
334332

335333
def __init__(self, version_a, version_b):
336-
337334
"""
338335
Argument(s):
339336
@@ -347,7 +344,6 @@ def __init__(self, version_a, version_b):
347344

348345
@property
349346
def changes(self):
350-
351347
"""
352348
Compile and return a dict describing changes between
353349
the two versions tracked in this diff
@@ -409,7 +405,6 @@ class Reverter:
409405
"""
410406

411407
def revert_fields(self, instance, field_versions, **kwargs):
412-
413408
"""
414409
Revert a set of fields
415410
@@ -434,7 +429,6 @@ def revert_fields(self, instance, field_versions, **kwargs):
434429
instance.save()
435430

436431
def rollback(self, instance, version, **kwargs):
437-
438432
"""
439433
Rollback to a specific version
440434
@@ -460,7 +454,6 @@ def rollback(self, instance, version, **kwargs):
460454
instance.save()
461455

462456
def validate_status_change(self, instance, status):
463-
464457
"""
465458
Validate a status value change - this will make sure
466459
an object cannot be undeleted if a parent relationship
@@ -484,7 +477,6 @@ def validate_status_change(self, instance, status):
484477
self.validate_parent_status(instance, relation, status)
485478

486479
def validate_parent_status(self, instance, parent, status):
487-
488480
if not hasattr(parent, "HandleRef"):
489481
return
490482

@@ -505,7 +497,6 @@ class ReversionReverter(Reverter):
505497
"""
506498

507499
def revert_fields(self, instance, field_versions, user=None):
508-
509500
"""
510501
Revert a set of fields
511502
@@ -540,7 +531,6 @@ def revert_fields(self, instance, field_versions, user=None):
540531
super().revert_fields(instance, field_versions)
541532

542533
def rollback(self, instance, version, user=None):
543-
544534
"""
545535
Rollback to a specific version
546536

tests/conftest.py

-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ def reversion_org_many():
6060

6161

6262
def pytest_configure():
63-
6463
settings.configure(
6564
ROOT_URLCONF="tests.urls",
6665
SECRET_KEY="mPqac6DEtYxY-0Mu946UUpg-YDVmXWkYj6L4rIE15_A",

tests/test_manager.py

-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ def test_last_change(self):
2828
self.assertEqual(Org.handleref.last_change(), org.updated)
2929

3030
def test_since(self):
31-
3231
org = self.orgs[0]
3332
t = time.time()
3433

tests/test_version.py

-2
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
],
2929
)
3030
def test_version_interface(field):
31-
3231
version = Version(object())
3332

3433
with pytest.raises(NotImplementedError):
@@ -103,7 +102,6 @@ def _test_rollback(org, versions, reverter):
103102

104103
@pytest.mark.django_db
105104
def test_reversion_version_fields(db):
106-
107105
with reversion.create_revision():
108106
org = VersionedOrg.objects.create(name="Test", status="ok")
109107

tests/urls.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
from django.conf import settings
2-
from django.conf.urls import include, re_path
32
from django.conf.urls.static import static
43

54
# auto admin
65
from django.contrib import admin
6+
from django.urls import re_path
77
from django.views.generic.base import RedirectView
88

99
admin.autodiscover()

0 commit comments

Comments
 (0)