fixes #128: module 'zmq.asyncio' has no attribute 'PUB'

fixes #126: zermoq plugin config validation wants both bind and connect to be set

Author: vegu

CHANGELOG.md

@@ -2,6 +2,9 @@
 
 
 ## Unreleased
+### Fixed
+- zmq.asyncio has no attribute `PUB` (#128)
+- zmq plugin configuration collision between bind and connect (#126)
 
 
 ## 1.4.2

CHANGELOG.yaml

@@ -1,6 +1,8 @@
 Unreleased:
   added: []
-  fixed: []
+  fixed:
+  - 'zmq.asyncio has no attribute `PUB` (#128)'
+  - 'zmq plugin configuration collision between bind and connect (#126)'
   changed: []
   deprecated: []
   removed: []

src/vaping/plugins/zeromq.py

@@ -1,4 +1,5 @@
 try:
+    from zmq import PUB
     import zmq.asyncio as zmq
 except ImportError:
     zmq = None
@@ -10,8 +11,8 @@
 
 
 class ZeroMQSchema(vaping.plugins.PluginConfigSchema):
-    bind = confu.schema.Str()
-    connect = confu.schema.Str()
+    bind = confu.schema.Str(default="")
+    connect = confu.schema.Str(default="")
 
 
 @vaping.plugin.register("zeromq")
@@ -41,22 +42,20 @@ def init(self):
         self.ctx = zmq.Context()
 
         # sanity check config
-        if "bind" in self.config:
-            if "connect" in self.config:
+        if self.config.get("bind"):
+            if self.config.get("connect"):
                 msg = "bind and connect are mutually exclusive"
                 self.log.critical(msg)
                 raise ValueError(msg)
-
-        elif "connect" not in self.config:
-            msg = "missing bind or connect"
+        elif not self.config.get("connect"):
             self.log.critical(msg)
             raise ValueError(msg)
 
     def on_start(self):
-        self.sock = self.ctx.socket(zmq.PUB)
-        if "bind" in self.config:
+        self.sock = self.ctx.socket(PUB)
+        if self.config.get("bind"):
             self.sock.bind(self.config["bind"])
-        elif "connect" in self.config:
+        elif self.config.get("connect"):
             self.sock.connect(self.config["connect"])
 
     def on_stop(self):