v3 API URL 'https://api.2fa.directory/v3/tfa.json' returns 404

[joshuacant]

• I have searched open issues and pull requests. The issue I'm creating is not a duplicate of an existing open issue or pull request.

Information about the bug:

Bug description:
The All 2FA-supporting sites 'https://api.2fa.directory/v3/tfa.json' v3 API url returns a github 404 error document instead of valid JSON

Bug reproduction:
Open https://api.2fa.directory/v3/tfa.json

Impacted devices:
All

Expected behavior:
https://api.2fa.directory/v3/tfa.json returns valid JSON

[Carlgo11]

Thanks for the bug report @joshuacant!
tfa.json and tfa.json.sig are now back.

Just out of curiosity, what's your use-case where you need to use tfa.json instead of a narrower output, like totp.json or u2f.json?

[joshuacant]

Thanks for fixing this so fast!

The question about use-case would have to be answered by @Rookiestyle who develops the KeePassOTP plugin (https://github.com/Rookiestyle/KeePassOTP) for an application called KeePass. I am just an end user of that plugin. It showed me an error message today when using it. I did a little digging and found this 404 was the root cause, so I raised the issue here.

[Carlgo11]

Oh, I didn't realize that you were an end-user 😅

@Rookiestyle I went through your code and I don't see any reason why it would need to fetch all 2FA-supporting sites instead of just those with TOTP support. Am I missing something?

[Rookiestyle]

@Carlgo11 This code is executed when a KeePass user opens the details of an entry. My plugin checks whether 2FA is possible and shows all the available options to the user.

Additionally, in the entry overview my plugin shows a column with the calculated OTP value or "Setup TFA" if this is possible - based on tfa.json.
Also it's possible for a user to define that he has "other 2FA" configured. Other being something different than TOTP. This way they can make the "Setup TFA" string go away if they e. g. have SMS active as second factor