-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give access to central Grafana to @colliand #1445
Comments
I have sent an invite to |
Even when I know @colliand can handle all the technical steps, maybe it makes sense to give him the pass through another tool (ie. Bitwarden)? Otherwise, I feel it is a lot of toil for him... |
I agree with @damianavila - I don't think that we should require all team members to understand In my opinion it would be fine to use something like Bitwarden's send feature to send the password. |
While I don't disagree, with the password manager approach we then run into a source of truth issue. We store the grafana admin password in the repo because it is automatically read by our deployment infrastructure when we deploy the support chart. If we change that password for whatever reason, we then have a monumental task on our hands updating everyone's password managers. I think an actual solution would be something more like GitHub Auth with Teams and let e.g. |
So I think a good plan is:
|
#1437 was merged, and we can now login into the central grafana using GitHub. "Viewer" access is granted based on the membership in @colliand, can you please try it out? Click on the |
Just a note that I agree w/ @sgibson91 and @GeorgianaElena's assessment above. My suggestion of sending via Bitwarden was just as a one-off, but I think that our long term focus should be on the guiding principle of:
I think the GitHub Auth login approach is great 👍 However I just tried to log in via this method, and after authorizing the github app, got: |
Yep, this issue should be fixed by #1460. @sgibson91, @choldgraf, can you please try again now? 🙏🏼 |
it works for me too! |
Yay! It works for me too. Now I need to learn how to use it! |
Since @colliand confirmed access we can call this one done. Awesome work @GeorgianaElena! |
Context
In #1438 (comment), @colliand asked for access to the central grafana.
Proposal
We should do this.
Updates and actions
Steps to be taken by @2i2c-org/tech-team:two-eye-two-see
projectcolliand@2i2c.org
the correct address to use for access to the project aboveSteps to be taken by @colliandgcloud
andsops
per instructions in https://team-compass.2i2c.org/en/latest/practices/secrets.html#set-up-sopssops
to decrypt the file which stores the password of the admin user of the central grafana by following the docs in:Update
#1437 was merged, and we can now login into the central grafana using GitHub. Access is granted based on the membership in 2i2c-org GitHub org.
The text was updated successfully, but these errors were encountered: