Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow gcp-filestore-backups to support multiple filestores #4449

Closed
3 tasks done
Tracked by #4391
sgibson91 opened this issue Jul 18, 2024 · 1 comment · Fixed by #4460
Closed
3 tasks done
Tracked by #4391

Allow gcp-filestore-backups to support multiple filestores #4449

sgibson91 opened this issue Jul 18, 2024 · 1 comment · Fixed by #4460
Assignees

Comments

@sgibson91
Copy link
Member

sgibson91 commented Jul 18, 2024

https://github.com/2i2c-org/infrastructure/blob/main/helm-charts/images/gcp-filestore-backups/gcp-filestore-backups.py was written to only accept a single name of a filestore instance to create backups for. However, in our terraform code we do actually permit deployment of multiple filestores (if only for the case to functionally permit resizing a GCP Filestore down). Is there a use case for gcp-filestore-backups to also backup multiple filestores in the same project?

What needs to be done?

  • Improve gcp-filestore-backups.py to accept multiple filestore names and check each for backups
  • Rebuild the gcp-filestore-backups image and update the support chart
  • Update support chart to permit an array of filestore names in schema
@yuvipanda yuvipanda changed the title Allow gcp-filestore-backups to support multiple filestores? Allow gcp-filestore-backups to support multiple filestores Jul 19, 2024
@yuvipanda
Copy link
Member

@sgibson91 yes, you should implement that! Do you need any more information than what you have? If this feels refined enough, please put this card in refined as part of the epic you're working on, and pick it up when you're done with the existing tasks there!

Thanks for catching this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants