Fix in-notebook config for culling kernels

[consideRatio]

Description

I think the following config section is inactive. We should use the proper configuration so that this code gets loaded as-expected and kernels are culled properly.

https://github.com/2i2c-org/pilot-hubs/blob/1565a35c031e66fe083fd5c6056c986938496b11/hub-templates/basehub/values.yaml#L1-L15

Benefit

Currently we aren't properly configuring our notebook culling, and so this is largely causing many clusters to behave in unexpected ways. Moreover, the current state gives us confidence that we have configured it a certain way, even though this isn't actually true, which is particularly problematic.

Implementation

This kind of config can be replaced by hub.extraFiles. See the hub.extraFiles docs

Tasks to complete

• Use extraFiles feature to cull idle kernels #563

[damianavila]

I don't see a trace of this config being referenced.

So that means we were not culling as we intended by that config stuff?

[consideRatio]

Yepp, i think thats correct to say @damianavila!

[yuvipanda]

Yep, we were only culling with the idle culler

[damianavila]

Thanks for the confirmation, folks!